APP APPROVALS

I think Garmin made a big change to the Approval Process during that 24+ hr outage a few days ago. Now app updates are being approved within minutes. Awesome!

mcinner1 4 months ago

…but at the moment it seems that approvals don‘t work…

I‘ve got many ERAs for Edge devices on getWeatherConditions. All Edges I‘m working for have Weather - so I did not check for has :Weather. Now I get a crash (not on simulator). Had to build all datafields anew. But they are not approved until now.

9142131 4 months ago in reply to mcinner1

see this thread forums.garmin.com/.../apps-stuck-in-pending-scan

jim_m_58 4 months ago in reply to mcinner1

You always want to null check everything in getCurrentConsitions, starting with what you get back from getCurrentConsitions itself

The one I see most often is the "feels like" temperature being null.

mcinner1 4 months ago in reply to jim_m_58

jim_m_58 said:
You always want to null check everything in getCurrentConsitions

As I said, all Edge devices I code for, have Weather. Therefore I have started with:

801 var myWeather = Weather.getCurrentConditions(); ….which never gave an error in the past!

Then I check myWeather for null and then I continue.

But the System Error occurs on line 801! Looks like :Weather is not ready, when it is called the first time in function compute(info).

jim_m_58 4 months ago in reply to mcinner1

It could be the weather isn't really ready. That's why you null check everything in "myWeather" you try to use. Not long ago, observationLocationName always became null on real devices, where before that there was usually an actual name.

FlowState 4 months ago in reply to jim_m_58

mcinner1 said:
Looks like :Weather is not ready

jim_m_58 said:
It could be the weather isn't really ready.

Hmm you don’t say

jim_m_58 said:
That's why you null check everything in "myWeather" you try to use.

How would that help prevent a system error on the following line?

mcinner1 said:
801 var myWeather = Weather.getCurrentConditions();

FlowState 4 months ago in reply to mcinner1

mcinner1 said:
All Edges I‘m working for have Weather - so I did not check for has :Weather. Now I get a crash (not on simulator). Had to build all datafields anew

mcinner1 said:
var myWeather = Weather.getCurrentConditions();

mcinner1 said:
System Error

Looks like there is a bug report for this:

[https://forums.garmin.com/developer/connect-iq/i/bug-reports/weather-getcurrentconditions-causes-crash-on-fenix-8]

Note that the example code in the bug report includes a has check (“Toybox has :Weather”), so if that’s what you added to your data fields to avoid this crash, I don’t think it will help.

I can’t see any way for devs to try to avoid this crash (other than not calling getCurrentConditions()). It think this is something Garmin has to fix on their end.

jim_m_58 4 months ago in reply to FlowState

Have you ever seen this in any of your apps that use Weather on any device?

mcinner1 4 months ago in reply to FlowState

FlowState said:
Note that the example code in the bug report includes a has check (“Toybox has :Weather”), so if that’s what you added to your data fields to avoid this crash, I don’t think it will help.

Yes, that‘s what I have added - and more:

var myWeather = null;
if ( Toybox has :Weather ) {
if ( Weather has :getCurrentConditions ) {
myWeather = Weather.getCurrentConditions();
}
}

Let‘s see what ERA brings the next days…

Thanks for your input!

_psx_ 4 months ago

I have the same: Error Name: System Error in line WEA.getCurrentConditions();

getCurrentConditions has to exist because error is not symbol not found