Big update to prettier-extension-monkeyc

Converting my code to SDK 9.1.0 compatible I get to this annoyance.

import Toybox.Application;
import Toybox.Application.Properties;
import Toybox.Application.Storage;
import Toybox.Lang;
import Toybox.System;

(:inline)
function getConfig(key as String) as Properties.ValueType or Null {
    var val;
    if (Application has :Properties) {
        val = Properties.getValue(key);
    } else {
        val = ((POCApp as Object?) as POCApp).getProperty(key) as Properties.ValueType?;
    }
    return val;
}

function getConfigNumber(key as String, defaultValue as Number) as Number {
    return toConfigNumber(getConfig(key), defaultValue);
}

function getStorage(key as String) as Storage.ValueType or Null {
    var val = null;
    if (Application has :Storage) { // ciq_2_4_0
        val = Storage.getValue(key);
    }
    return val;
}

function getStorageNumber(key as String, defaultValue as Number) as Number {
    return toConfigNumber(getStorage(key), defaultValue);
}

function toConfigNumber(value as Properties.ValueType /*or Storage.ValueType*/ or Null, defaultValue as Number) as Number {
    if (value instanceof Lang.Boolean) {
        return value ? 1 : 0;
    }
    // this should cover Float, Double, Number, String, Long, Char, Symbol
    value = value != null && value has :toNumber ? value.toNumber() : null;
    return value != null ? value as Number : defaultValue;
}

If I add "or Storage.ValueType" to the 1st parameter of toConfigNumber, then I get this error:

ERROR> fr245: Config.mc:19:27: Argument 1 to $.toConfigNumber: passing Null or Boolean or Number or Long or Float or Double or String or Array<Toybox.Application.Properties.ValueType> to parameter Null or Boolean or Number or Long or Float or Double or Char or String or Array<Toybox.Application.Properties.ValueType> or Array<Toybox.Application.Storage.ValueType> or Dictionary<Boolean or Number or Long or Float or Double or Char or String, Toybox.Application.Storage.ValueType> or Toybox.Application.WatchFaceConfig.Id or Toybox.BluetoothLowEnergy.ScanResult or Toybox.Complications.Id or Toybox.Graphics.BitmapReference or Toybox.Lang.ByteArray or Toybox.WatchUi.AnimationResource or Toybox.WatchUi.BitmapResource is not type safe [more info: github.com/.../Extra-Reference-Type-Checks-(prettierMonkeyC.extraReferenceTypeChecks)]

Until now it worked with PropertyValueType. I know it's just a warning, but maybe there can be done something about it? I mean I even guess that it's a problem that it's hard to detetmine what value.someMethod() can do, and so value.toNumber() is kind of risky, but I get the same error if I remove this line from toConfigNumber:

You're talking about Garmin's optimizer here, yes?

No. When I compile without Prettier Optimizer, then there's no warning at all. Only when I compile with Prettier I get this error(warning)

It's complaining about passing the result of getConfig(key) (not sure what that is) to a parameter of type Storage.ValueType.

So yes, in theory it could analyze toConfigNumber and see that it doesn't do anything dangerous with value, and suppress the warning - but that's not something I've implemented (it does do some analysis for very simple callees, but that doesn't apply here).

As far as I can see, the warning has nothing to do with the toNumber call - I'm not quite sure what you're asking?

Hmm. As it says in the header, I was replying to  https://forums.garmin.com/developer/connect-iq/f/discussion/294852/big-update-to-prettier-extension-monkeyc/2018297 which doesn't mention an error or warning. So again, I assume your post about the failure to optimize constants is talking about Garmin's compiler, not my optimizer...