Big update to prettier-extension-monkeyc

PMC incorrectly detects draw function:

import Toybox.Graphics;
import Toybox.Lang;
import Toybox.WatchUi;

function onUpdate(dc as Dc) as Void {
  var statusIcon;
  if (displayPlayUntil != null) {
    statusIcon = new Rez.Drawables.play();
  } else {
    statusIcon = null;
  }
  if (statusIcon != null) {
    statusIcon.draw(dc);
  }
}

$.Toybox.WatchUi.CustomMenu.draw expects 2 arguments, but got 1 [pmc-analysis]

flocsy🤠 said:

feature-request: possibility to only do optimization for certain devices

That seems reasonable.

I think the simplest way would be to have an option specifying a device memory limit. ie only optimize for devices with less than X kb of memory. One issue with that though is that the cutoff could also be dependent on feature set. For example one of my data fields includes on device settings when supported. For devices that don't support on-device settings, 32k is plenty without my optimizer. But there are a number of devices with 32k, some of which support on device settings, and some of which don't.

An alternative would be a no_optimization exclude annotation. You could then specify on a per-device basis whether or not to optimize.

Or I suppose both would be do-able too.

flocsy🤠 said:

Of course adding "as Number?" at line 7 helps, but I wonder why the compiler (SDK 8.1.0, typecheck:3) is ok with it and Prettier doesn't like it?

Typically this particular issue is because my type checker recognizes that _sport.format might actually call Lang.format, if the type of _sport isn't known (specifically enough). On the other hand, Garmin's type checker assumes that because you're calling "<some object>.format", you must be calling one of the Object.format methods, and doesn't complain. This is not necessarily true at runtime.

However, in this case, it does look like my type checker has failed to determine the type of _sport correctly. I'll take a look.

Both sounds great. As for the annotation, maybe optimize would be more useful, as it's usually used for the old devices (i.e 16k), while the new ones can be left alone until lets say new features make it also necessary for devices with 32k as well.