Big update to prettier-extension-monkeyc

v2.0.112 is out.

This fixes a couple of issues

• Unexpected type for ResourceId of personality bitmap
• Incorrect typing for array of tuples

It also improves type checking for tuples and arrays, with an option to revert to Garmin's behavior.

v2.0.114 is out.

Fixes

• Adding to a tuple would change its type" after assigning empty tuple to typed class variable
• Argument 1 to Dictionary.get expected to be Number<0> as Enum but got Number<0>
• Invalid assignment to tuple at index

v2.0.116 is out.

This fixed an issue with export, when the post build optimizer was enabled. Sdk-7.4.3 changed the .iq file format very slightly, but enough that the post build optimizer bailed with an exception. In addition, I didn't handle the exception correctly, and vscode thought the task hadn't finished, and would sit waiting forever.

v2.0.118 is out.

• Fixes the parser to allow extra semi-colons after expression statements, and uncontrolled blocks, to match Garmin's
• Fixes a crash resulting in strange error messages if there were no devices in the manifest

markw65 I revisited one of my apps that I haven't worked on for a few months, and I get new errors (warnings?) like:

ERROR> fenix6: Config.mc:30:5: Argument 1 to $.convertToString: passing Null or Boolean or Number or Long or Float or Double or Char or String or Array<Toybox.Application.PropertyValueType> or Dictionary<Boolean or Number or Long or Float or Double or Char or String, Toybox.Application.PropertyValueType> or Toybox.WatchUi.BitmapResource to parameter Null or Object is not type safe [more info: https://github.com/markw65/monkeyc-optimizer/wiki/Extra-Reference-Type-Checks-(prettierMonkeyC.extraReferenceTypeChecks)]
inlined from $.toConfigStr in Config.mc:34:29
ERROR> fenix6: Config.mc:30:5: Argument 1 to $.convertToString: passing Dictionary<Boolean or Number or Long or Float or Double or Char or String, Toybox.Application.PropertyValueType> to parameter Dictionary is not type safe [more info: https://github.com/markw65/monkeyc-optimizer/wiki/Extra-Reference-Type-Checks-(prettierMonkeyC.extraReferenceTypeChecks)]]
inlined from $.toConfigStr in Config.mc:34:29

1. I don't understand why there are 2 errors that are almost (but not exactly) identical

2. I understand the explanation and the examples in github, but I don't understand why they apply here. My only guess is that your code sees value.toString() and thinks it can change value? Because I don't see why this is unsafe.

monkey.jungle:

fenix6.excludeAnnotations=$(fenix6.excludeAnnotations);no_ciq_2_4_0

ERROR> fenix6: MyField.mc:974:9: This comparison seems redundant because HR_ZONES_MOCK should never be null

I understand that in the context of the specific build it's always an array and can never be null, but it can be null in release builds, so I don't feel like this error message is "fair".

markw65 I think I found a bug. I get this error message:

ERROR: fenix6: bin/optimized/group052-debug/source/source/MyField.mc:1154,20: Passing 'PolyType<Null or $.HrAlertView>' as parameter 1 of non-poly type '$.Toybox.WatchUi.DataFieldAlert'.

It looks like the generated code is incorrect. I see the problem there, but I am not able to create a small file to reproduce it. It looks like it has to do with the huge inline functions nested in each other. Is there a way to send you a meaningful debug output?

The problem is something like this:

The problem is that in the generated code it checks for alertview == null instead of pmcr_alertView_0 == null. Interestingly enough in all the code I tried to create for POC it does check pmcr_alertView_0.

flocsy🤠 said:

I understand that in the context of the specific build it's always an array and can never be null, but it can be null in release builds, so I don't feel like this error message is "fair".

import Toybox.Lang;

(:release)
function getDefaultSetting() as Number {
    return 0;
}
(:debug)
function getDefaultSetting() as Array<Number> {
    return [0, 1];
}

(:release)
function getSetting() as Number {
    var setting = getDefaultSetting();
    // ...
    return setting; // Expected $.getSetting to return Number but got Number or Array<Number>
}
(:debug)
function getSetting() as Array<Number> {
    var settingsArray = getDefaultSetting();
    // ...
    return settingsArray; // Expected $.getSetting to return Array<Number> but got Number or Array<Number>
}