• Replies 1063 replies
  • Subscribers 27 subscribers
  • Views 105894 views
  • Users 0 members are here
Options
Related

Big update to prettier-extension-monkeyc

markw65
over 2 years ago

I've posted about prettier-extension-monkeyc before, but I've added a bunch of new features that developers will probably like (well, I've been missing them, so maybe you have too).

The new features it implements for VSCode include:

  • Goto Definition. Point at a symbol, Ctrl/Cmd click, and it will take you to the definition. Or F12
  • Goto References. Right click on a symbol and select "Goto References". It will show you all the references. Or Shift-F12
  • Peek Definition/Peek References. Same as above, but in a popup window so you don't lose your place in the original document.
  • Rename Symbol. Right click on a local, function, class or module name, and select "Rename Symbol". It will rename all the references. It doesn't yet work for class members/methods.
  • Goto Symbol. Type Ctrl/Cmd-Shift-O and pick a symbol from the drop down (which has a hierarchical view of all symbols in the current file). This also appears as an outline across the top of the file.
  • Open Symbol By Name. Type Ctrl/Cmd-T, then start typing letters from a symbol name. A drop down will be populated with all matching symbols from anywhere in your project.

Older features include a prettier based formatter for monkeyc, and a monkeyc optimizer that will build/run/export an optimized version of your project.

[edit: My last couple of replies seem to have just disappeared, and the whole conversation seems to be in a jumbled order, so tldr: there's a new test-release at https://github.com/markw65/prettier-extension-monkeyc/releases/tag/v2.0.9 which seems to work for me on linux. I'll do more verification tomorrow, and push a proper update to the vscode store once I'm sure everything is working]

  • 5 months ago in reply to markw65

    LOL, I think similar issue here. Can you improve this? https://github.com/markw65/monkeyc-optimizer/issues/17 Or at least add some information so we know where to look?

  • 5 months ago in reply to flocsy
    flocsy said:
    Can you improve this

    I think what happened is that originally the parser rejected enums with expressions, so the optimizer treated it as an internal error that should never be able to happen. But at some point I extended the parser to handle expressions, but didn't fix the optimizer. As a result it doesn't get reported properly.

    So this is even worse than issue 17 - because you don't even get a notification that there's a problem in the project.

    I will definitely fix this so that enums are handled properly. I think there are a few things I can do to make issue 17 a bit better, so that an error in a single file only affects that file, and not the whole project. But even that has a downside - it will report lots of missing symbols against the other files...

  • 5 months ago

    I managed to work around some SDK 7.1.0 bugs when compiling without prettier-optimizer, and I am trying now with prettier, but it fails:

    > Sizes for optimized-Myapp.original-fr955: code: 16814 data: 7161 <
    > Optimizing optimized-Myapp.original.prg to optimized-Myapp.prg <
    Post-build failed: TypeError: Cannot read properties of undefined (reading 'view')

    What can I do to give you some information?

    update: it only happens when compiling for system7 devices.

  • 5 months ago in reply to flocsy
    flocsy said:
    update: it only happens when compiling for system7 devices

    That does it for me too. Investigating...

  • 5 months ago in reply to flocsy

    They've made some changes to the prg file format. That was mostly minor changes that were easy to deal with.

    But they've also added a whole slew of new opcodes - which is going to take a while; I've got to figure out what they do, and then implement them.

    So I'm going to work on it, but don't hold your breath.

    Meanwhile, some the opcodes look like they might be pretty useful. Eg I think they've added bytecodes to construct "literal" arrays. Where previously, something like

    var a = [1, 2, 3];

    was basically syntactic sugar for

    var a = new [3];
a[0] = 1;
a[1] = 2;
a[2] = 3;

    I think there's a new opcode that just initializes the array from a read-only copy in memory. That should be a big memory win - but only on new devices that probably don't need it...

  • 5 months ago in reply to markw65
    markw65 said:
    I think there's a new opcode that just initializes the array from a read-only copy in memory. That should be a big memory win - but only on new devices that probably don't need it...

    Oh man this brings back terrible memories of trying to handle large-ish amounts of static data in old devices with tiny RAM for data fields and no support for JSON resources.

  • 5 months ago in reply to FlowState

    Yeah, the problem with many of the improvements Garmin does is that it would be most needed on the oldest devices, but they add it only to the newest which don't really need the optimizer at all, because there's enough memory even without using it...

  • 5 months ago in reply to markw65

    Ah, I thought all these were already added in sdk 7.0.0 and you already had them added.

    Maybe until you do all the necessary opcodes add an error message that: "The prg uses unknown opcodes, disable Post Build Optimizer in the settings."

  • 5 months ago in reply to flocsy
    flocsy said:
    Yeah, the problem with many of the improvements Garmin does is that it would be most needed on the oldest devices, but they add it only to the newest which don't really need the optimizer at all, because there's enough memory even without using it...

    Agreed, but I'll give them props for adding the "settings" scope for strings which is a huge win for older devices and a feature request I never thought they'd fulfill.

    I don't blame Garmin for not making improvements to older devices that they don't sell or support anymore tho. It just so happens that most Garmin users hold on to their devices for much longer than usual, which might make it tough for CIQ devs to decide whether or not to support older devices.

  • 5 months ago in reply to FlowState

    I missed that! Where was it announced? I wish they would properly "close" the tickets we open in the bug forum...

    update: found: developer.garmin.com/.../