Big update to prettier-extension-monkeyc

flocsy🤠 said:

I don't think that the constant folding can explain this

Then maybe it really is the signature check, and the "out of memory" error is just a bogus error message. What device are you trying to run on? Perhaps newer devices do care about the signature?

flocsy🤠 said:

actually I don't remember if I did a build or just copied the already existing prg to the device

So for me, that seems to work. But the docs explicitly say that you have to do a "device" build, rather than a simulator build if you're going to run on a device. With the optimizer, you would have to use a task in tasks.json, and include 

No, this is an old fenix6. And yes, that may be the issue. I'll recheck it. So "Export Optimized Project" isn't ok? Do you have an example tasks.json? I've never seen one, I only have launch.json

Also I've found a new bug:

(:release, :inline)
function log(msg as String) as Void {}
(:debug, :inline)
function log(msg as String) as Void {
    if (LOG) {
        logRelease(msg);
    }
}

function logRelease(msg as String?) as Void {
    var time = timeFormat(Time.now());
    System.println(time + " " + msg);
}

(:no_inline)
function timeFormat(moment as Moment) as String {
    var time = Time.Gregorian.info(moment as Moment, Time.FORMAT_SHORT);
    var ms = System.getTimer() % 1000;
    return "" + time.hour.format("%02d") + ':' + time.min.format("%02d") + ':' + time.sec.format("%02d") + "." + ms.format("%03d");
}

class Foo {
    hidden function foo(bar as String) as Void {
        log("foo: " + bar);
    }
}

ERROR: fenix6: Foo.mc:391,4: Undefined symbol ':msg' detected.

the optimized-debug code:

  hidden function foo(bar as String) as Void {
    logRelease(msg);
  }

flocsy🤠 said:

So "Export Optimized Project" isn't ok?

"Export Optimized Project" produces a .iq file, so yes, that should be fine. Its both building for specific devices, and the signatures get updated.

"Build Optimized Project" or "Build and Run Optimized Project" build for the simulator (so in theory the .prg files may not work on a device), and they don't fix the signature after the build.

Example task:

{
  "type": "omonkeyc",
  "device": "fr255",
  "simulatorBuild": false,
  "releaseBuild": true,
  "label": "FR255 Device Build",
},

I'll take a look at the bug...

flocsy🤠 said:

ERROR: fenix6: Foo.mc:391,4: Undefined symbol ':msg' detected.

I don't get this with your example. To make your example work, I added various imports at the top, and a "const LOG=true". But then "hidden function foo" is removed entirely. If I add eg an initialize function that calls foo, or use (:keep) to prevent foo from being removed, I get:

  hidden function foo(bar as String) as Void {
    logRelease("foo: " + bar);
  }

as expected.

Can you make a standalone example that builds, and has the issue?

import Toybox.Lang;
import Toybox.System;
import Toybox.Time;

(:debug) const LOG = true;
(:release) const LOG = false;

(:release, :inline)
function log(msg as String) as Void {}
(:debug, :inline)
function log(msg as String) as Void {
    if (LOG) {
        logRelease(msg);
    }
}

function logRelease(msg as String?) as Void {
    var time = timeFormat(Time.now());
    System.println(time + " " + msg);
}

(:no_inline)
function timeFormat(moment as Moment) as String {
    var time = Time.Gregorian.info(moment as Moment, Time.FORMAT_SHORT);
    var ms = System.getTimer() % 1000;
    return "" + time.hour.format("%02d") + ':' + time.min.format("%02d") + ':' + time.sec.format("%02d") + "." + ms.format("%03d");
}

class Foo {
    function initialize() {
        foo("FOO");
    }

    hidden function foo(word as String) as Void {
        log("foo: " + word);
        var msg = "bingo!";
    }
}

OK, now it's pretty clear what causes it. The next line :) 

Wow. It actually has nothing to do with inlining. If you write

function bar(bar as String) as Void {
  {
    var msg = bar;
    log(msg);
  }
  var msg = "foo";
}

Then at the end of the block that declares the second "msg" variable, the optimizer notices that msg wasn't used, and removes all assignments to it from within the block, including inner blocks. I remember thinking when I wrote this that I didn't need to check for that case because Garmin's compiler doesn't allow multiple variables with the same name in the scope at any given time... but of course, in this case there is only ever one live variable named "msg", so the compiler allows it.

The connection with inlining is that when the compiler inlines "log", it creates an inner block, with an inner "msg" variable, just like the above example.

markw65 said:

The post build optimizer doesn't bother to fix the signature

I misspoke. It always fixes it, whether you're exporting, or just running locally.

New version v2.0.79:

added all the missed ones (even ones that you probably haven't missed, but kept for later) and added a new one about concatenating or adding all types of objects to string.