Issue debugging settings

There have been problems with Garmin Connect Mobile and the settings system. One of the problems is that the setting can come back as the wrong type (you expect a Lang.Number, but the system provides a Lang.String that is convertible to the number, but will throw an exception if you use it in a context where a number is expected). You should be able to combat this problem by checking the type before using the value.

I've written a wrapper around the object store in an attempt to avoid this problem. I haven't used this in production yet, but it seems that it should work. If the value returned by the object store is the correct type, the value is returned. If the value is a string, a conversion is made. Otherwise, the default value provided is returned.

module Settings {

using Toybox.Application as App;
using Toybox.Lang as Lang;

function setProperty(name, val) {
    App.getApp().setProperty(name, val);
}

function getProperty(name, initial) {
    var val = App.getApp().getProperty(name);
    if (val != null) {
        return val;
    }

    return initial;
}

function deleteProperty(name) {
    App.getApp().deleteProperty(name);
}

function clearProperties() {
    App.getApp().clearProperties();
}

function getStringProperty(key, initial) {
    var value = App.getApp().getProperty(key);
    if (value != null) {

        if (value instanceof Lang.String) {
            return value;
        }
        else if (value instanceof Lang.Double ||
            value instanceof Lang.Float ||
            value instanceof Lang.Long ||
            value instanceof Lang.Number) {
            return value.toString();
        }
    }

    return initial;
}

function setStringProperty(key, value) {
    assert(value instanceof Lang.String);
    App.getApp().setProperty(key, value);
}

function getBooleanProperty(key, initial) {
    var value = App.getApp().getProperty(key);
    if (value != null) {

        if (value instanceof Lang.Boolean) {
            return value;
        }
        else if (value instanceof Lang.Double ||
            value instanceof Lang.Float ||
            value instanceof Lang.Long ||
            value instanceof Lang.Number ||
            value instanceof Lang.String) {
            return value.toNumber() != 0;
        }
    }

    return initial;
}

function setBooleanProperty(key, value) {
    assert(value instanceof Lang.Boolean);
    App.getApp().setProperty(key, value);
}

function getNumberProperty(key, initial) {
    var value = App.getApp().getProperty(key);
    if (value != null) {

        if (value instanceof Lang.Number) {
            return value;
        }
        else if (value instanceof Lang.Boolean) {
            return value ? 1 : 0;
        }
        else if (value instanceof Lang.Double ||
            value instanceof Lang.Float ||
            value instanceof Lang.Long ||
            value instanceof Lang.String) {
            return value.toNumber();
        }
    }

    return initial;
}

function setNumberProperty(key, value) {
    assert(value instanceof Lang.Number);
    App.getApp().setProperty(key, value);
}


function getFloatProperty(key, initial) {
    var value = App.getApp().getProperty(key);
    if (value != null) {

        if (value instanceof Lang.Float) {
            return value;
        }
        else if (value instanceof Lang.String) {
            return value.toFloat();
        }
        else if (value instanceof Lang.Boolean) {
            return value ? 1.0f : 0.0f;
        }
        else if (value instanceof Lang.Double ||
            value instanceof Lang.Long ||
            value instanceof Lang.Number) {
            return value.toFloat();
        }
    }

    return initial;
}

    function setFloatProperty(key, value) {
        assert(value instanceof Lang.Float);
        App.getApp().setProperty(key, value);
    }
}

<setting propertyKey="@Properties.COLOR_Text" title="@Strings.UI_STR_Text_color">
  <settingConfig type="list">
    <listEntry value="0">@Strings.UI_COLOR_White</listEntry>
    <listEntry value="1">@Strings.UI_COLOR_Gray</listEntry>
    <listEntry value="2">@Strings.UI_COLOR_Dark_Gray</listEntry>
    <listEntry value="3">@Strings.UI_COLOR_Black</listEntry>
    <listEntry value="4">@Strings.UI_COLOR_Red</listEntry>
    <listEntry value="5">@Strings.UI_COLOR_Dark_Red</listEntry>
    <listEntry value="6">@Strings.UI_COLOR_Green</listEntry>
    <listEntry value="7">@Strings.UI_COLOR_Dark_Green</listEntry>
    <listEntry value="8">@Strings.UI_COLOR_Blue</listEntry>
    <listEntry value="9">@Strings.UI_COLOR_Dark_Blue</listEntry>
    <listEntry value="10">@Strings.UI_COLOR_Orange</listEntry>
    <listEntry value="11">@Strings.UI_COLOR_Yellow</listEntry>
    <listEntry value="12">@Strings.UI_COLOR_Purple</listEntry>
    <listEntry value="13">@Strings.UI_COLOR_Pink</listEntry>
  </settingConfig>
</setting>

var color_map = {
  0 => Gfx.COLOR_WHITE,
  1 => Gfx.COLOR_LT_GRAY,
  2 => Gfx.COLOR_DK_GRAY,
  3 => Gfx.COLOR_BLACK,
  4 => Gfx.COLOR_RED,
  5 => Gfx.COLOR_DK_RED,
  6 => Gfx.COLOR_GREEN,
  7 => Gfx.COLOR_DK_GREEN,
  8 => Gfx.COLOR_BLUE,
  9 => Gfx.COLOR_DK_BLUE,
  10 => Gfx.COLOR_ORANGE,
  11 => Gfx.COLOR_YELLOW,
  12 => Gfx.COLOR_PURPLE,
  13 => Gfx.COLOR_PINK
}

function get_color_for_value(val) {
    var color = color_map[val];
    if (color != null) {
      return color;
    }

    return Gfx.COLOR_RED;
}

<!--COLOR_PURPLE = 0xAA00FF Purple. Not valid on Fenix 3 or D2 Bravo. Use 0x5500AA instead. -->